Skip to content

refactor(core): add a filter to get deprecated ArgSpec #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2020
Merged

refactor(core): add a filter to get deprecated ArgSpec #1446

merged 3 commits into from
Sep 15, 2020

Conversation

@jerome-quere
Copy link
Contributor

@jerome-quere jerome-quere commented Sep 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

QuentinBrosse
QuentinBrosse reviewed Sep 15, 2020
View reviewed changes
QuentinBrosse
QuentinBrosse previously approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere @QuentinBrosse
Update internal/core/arg_specs.go
c1992f4 
Co-authored-by: Quentin Brosse <quentin.brosse@icloud.com>
QuentinBrosse
QuentinBrosse approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 71f1701 into scaleway:master Sep 15, 2020
@jerome-quere jerome-quere deleted the filter-deprecated branch September 15, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerome-quere @QuentinBrosse