Skip to content

Conversation

@remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC This is not compliant with go module versioning, You should move everything in a v2 folder.

Also this should not be usable as a go module we should not encourage usage of this repo as a library package

@remyleone
Copy link
Member Author

https://blog.golang.org/v2-go-modules

I mostly did it to enable to have the right answers for
go list -m -versions github.com/scaleway/scaleway-cli

It would also enable go install github.com/scaleway/scaleway-cli/cmd/scw@latest to work natively

@remyleone
Copy link
Member Author

Fixed by #2347

@remyleone remyleone closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants