Skip to content

Improve _cs format #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2015
Merged

Improve _cs format #225

merged 2 commits into from
Oct 21, 2015

Conversation

@QuentinPerez
Copy link
Contributor

@QuentinPerez QuentinPerez commented Oct 19, 2015

#223

$> ./scw _cs
s3://datas
$> ./scw _cs datas
2015-10-07 11:28    310kB s3://datas/text.txt
2015-10-07 11:28    100kB s3://datas/binaire

@moul
Copy link
Contributor

moul commented Oct 19, 2015

can you also require a "s3://" prefix when using a path ?

$> ./scw _cs
s3://datas
$> ./scw _cs s3://datas
2015-10-07 11:28    310kB s3://datas/text.txt
2015-10-07 11:28    100kB s3://datas/binaire

@QuentinPerez
Copy link
Contributor Author

QuentinPerez commented Oct 19, 2015

Yes

@moul
Copy link
Contributor

moul commented Oct 21, 2015

LGTM

@moul
Copy link
Contributor

moul commented Oct 21, 2015

no sorry, update the README.md please

@moul
Copy link
Contributor

moul commented Oct 21, 2015

Can you make a party -c -t -d=vendor in a separated commit ?

houndci-bot
houndci-bot reviewed Oct 21, 2015
View reviewed changes
pkg/scwversion/version.go
Copy link

@houndci-bot houndci-bot Oct 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported var VERSION should have comment or be unexported

moul added a commit that referenced this pull request Oct 21, 2015
@moul
Merge pull request #225 from QuentinPerez/improve_cs
14b0a96 
Improve _cs format
@moul moul merged commit 14b0a96 into scaleway:master Oct 21, 2015
@moul moul removed the in progress label Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuentinPerez @moul @houndci-bot