Skip to content

Check go version in cmd/scw too #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2015
Merged

Check go version in cmd/scw too #232

merged 1 commit into from
Nov 5, 2015

Conversation

@QuentinPerez
Copy link
Contributor

@QuentinPerez QuentinPerez commented Nov 5, 2015 

root@733000e59cca:~/bin# eval "$(GIMME_GO_VERSION=1.4 ./gimme)"
go version go1.4 linux/amd64
root@733000e59cca:~/bin# go get -u github.com/QuentinPerez/scaleway-cli/cmd/scw
# github.com/QuentinPerez/scaleway-cli/cmd/scw
../src/src/github.com/QuentinPerez/scaleway-cli/cmd/scw/main_unsupported.go:6: "Bad go version, please install a version greater than or equal to 1.5" evaluated but not used
root@733000e59cca:~/bin# rm -fr /root/src/*
root@733000e59cca:~/bin# eval "$(GIMME_GO_VERSION=1.5 ./gimme)"
go version go1.5 linux/amd64
root@733000e59cca:~/bin# go get -u github.com/QuentinPerez/scaleway-cli/cmd/scw
root@733000e59cca:~/bin#

@moul
Copy link
Contributor

moul commented Nov 5, 2015

LGTM

moul added a commit that referenced this pull request Nov 5, 2015
@moul
Merge pull request #232 from QuentinPerez/go_version
cc72f5d 
Check go version in cmd/scw too
@moul moul merged commit cc72f5d into scaleway:master Nov 5, 2015
@moul moul removed the in progress label Nov 5, 2015
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@kindermoumoute
fix: avoid panic when running without config file (scaleway#232)
2dadfd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuentinPerez @moul