Add region and arch field for images #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QuentinPerez
commented
Jan 6, 2016
QuentinPerez
commented
pkg/api/cache.go
Outdated
Contributor
There was a problem hiding this comment.
you don't need to specify iota each time
added 9 commits
January 6, 2016 17:26
Contributor
There was a problem hiding this comment.
Do you have an example of the new output with the title under the list of candidates ?
Contributor
Author
There was a problem hiding this comment.
- 5f19794c bootscript:3-2-34-apparmor-31 3.2.34-apparmor #31 arm
- 7c7fcac7 bootscript:4-2-5-apparmor-259 4.2.5-apparmor #259 arm
- 1e7a3063 bootscript:armv7l-4-3-3-std-1-latest armv7l 4.3.3 std #1 (latest) arm
FATA[0000] cannot execute 'run': failed to create server: Too many candidates for m (3)
pkg/api/api.go
Outdated
Contributor
There was a problem hiding this comment.
I think that you will soon need to add the region here, so maybe we should switch to a structure
Contributor
|
LGTM, you can fix my comments now or later as they are clearly not important We need to test this version for a while so we can adjust the details, so as soon as the PR is merged, I will create a pre-release |
QuentinPerez
pushed a commit
that referenced
this pull request
Jan 8, 2016
Add region and arch field for images
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.