Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Mar 16, 2023

Fix #1171
Fix #1006

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #2878 (93f28af) into master (0611b06) will decrease coverage by 0.21%.
The diff coverage is 55.13%.

@@            Coverage Diff             @@
##           master    #2878      +/-   ##
==========================================
- Coverage   75.07%   74.86%   -0.21%     
==========================================
  Files         151      157       +6     
  Lines       32080    32421     +341     
==========================================
+ Hits        24084    24272     +188     
- Misses       7147     7293     +146     
- Partials      849      856       +7     
Impacted Files Coverage Δ
internal/editor/doc.go 0.00% <0.00%> (ø)
internal/editor/tempfile.go 0.00% <0.00%> (ø)
...al/namespaces/instance/v1/custom_security_group.go 55.32% <30.50%> (-3.93%) ⬇️
internal/editor/editor.go 37.66% <37.66%> (ø)
internal/editor/marshal.go 40.00% <40.00%> (ø)
internal/editor/reflect.go 95.69% <95.69%> (ø)
internal/editor/request.go 100.00% <100.00%> (ø)
internal/namespaces/instance/v1/custom.go 98.07% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax force-pushed the feat/editor branch 4 times, most recently from 002b95c to ec7bb74 Compare March 24, 2023 14:38
@Codelax Codelax marked this pull request as ready for review March 24, 2023 14:59
@remyleone remyleone added this pull request to the merge queue Mar 27, 2023
Merged via the queue into scaleway:master with commit 6ec08ac Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tooling to edit complex data in a text editor Add custom rule edition for security groups using an $EDITOR

3 participants