Skip to content

login: Don't print message when we are no keys #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2016
Merged

login: Don't print message when we are no keys #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2c272b
login: Don't print message when we are no keys
Mar 18, 2016
f694527
Update README.md
Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@ $ scw inspect myserver | jq '.[0].public_ip.address'

### master (unreleased)

* No entry
* `scw login` don't ask to upload ssh key when there is no keys

View full [commits list](https://github.com/scaleway/scaleway-cli/compare/v1.8.0...master)

Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ type LoginArgs struct {

// selectKey allows to choice a key in ~/.ssh
func selectKey(args *LoginArgs) error {
fmt.Println("Do you want to upload an SSH key ?")
home, err := config.GetHomeDir()
if err != nil {
return err
Expand All @@ -52,6 +51,7 @@ func selectKey(args *LoginArgs) error {
if len(pubs) == 0 {
return nil
}
fmt.Println("Do you want to upload an SSH key ?")
fmt.Println("[0] I don't want to upload a key !")
for i := range pubs {
fmt.Printf("[%d] %s\n", i+1, pubs[i])
Expand Down