Skip to content

Revert "feat(redis): require the node_type field in MigrateClusterRequest" This reverts merge request !3058 #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Revert "feat(redis): require the node_type field in MigrateClusterRequest" This reverts merge request !3058 #3706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ USAGE:

ARGS:
[version] Redis™ engine version of the Database Instance
node-type Type of node to use for the Database Instance
[node-type] Type of node to use for the Database Instance
[cluster-size] Number of nodes for the Database Instance
cluster-id UUID of the Database Instance to update
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2)
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/redis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ scw redis cluster migrate <cluster-id ...> [arg=value ...]
| Name | | Description |
|------|---|-------------|
| version | | Redis™ engine version of the Database Instance |
| node-type | Required | Type of node to use for the Database Instance |
| node-type | | Type of node to use for the Database Instance |
| cluster-size | | Number of nodes for the Database Instance |
| cluster-id | Required | UUID of the Database Instance to update |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/redis/v1/redis_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ func redisClusterMigrate() *core.Command {
{
Name: "node-type",
Short: `Type of node to use for the Database Instance`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
Expand Down