Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Jul 2, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added the instance Instance issues, bugs and feature requests label Jul 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 90.05236% with 19 lines in your changes missing coverage. Please review.

Project coverage is 69.28%. Comparing base (5bf53e0) to head (e09e2dd).
Report is 136 commits behind head on master.

Files Patch % Lines
...spaces/instance/v1/custom_server_create_builder.go 89.61% 11 Missing and 5 partials ⚠️
...nal/namespaces/instance/v1/custom_server_create.go 91.89% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (e09e2dd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (e09e2dd)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
- Coverage   75.45%   69.28%   -6.17%     
==========================================
  Files         202      291      +89     
  Lines       44323    55178   +10855     
==========================================
+ Hits        33444    38231    +4787     
- Misses       9653    15375    +5722     
- Partials     1226     1572     +346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the refactor/instance-server-create branch from fd8da94 to d8fd5d7 Compare July 3, 2024 08:33
@Codelax Codelax marked this pull request as ready for review July 3, 2024 12:06
@Codelax Codelax requested a review from remyleone as a code owner July 3, 2024 12:08
@remyleone remyleone added this pull request to the merge queue Jul 3, 2024
Merged via the queue into scaleway:master with commit 52bfdcc Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants