Skip to content

Build improvements #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2017
Merged

Build improvements #453

merged 6 commits into from
Apr 3, 2017

Conversation

@brmzkw
Copy link
Contributor

@brmzkw brmzkw commented Apr 3, 2017

I made some changes to the build of scaleway-cli:

  • add MAINTAINERS.md to document everything that needs to be done when releasing the package
  • remove goxc: goxc is outdated and can be replaced with the native cross-compile tool of Go>=1.5

Any objection?

CC @moul @QuentinPerez @bchatelard

Julien Castets added 5 commits March 31, 2017 12:00
Remove Makefile rule ".git"
674b635 
Introduced in 4560ecf, the rule .git was a dependency of
scwversion/version.go which has been removed in 60bfe24.
Remove homebrew/scw.rb
bce429f 
scaleway-cli is now an official homebrew package. The formula doesn't
need to be maintained in this repository.
Makefile: goxc: remove invalid option of docker tag
398166a
Cross-compile scaleway-cli with standard tools
40cd43d 
goxc used to be a simple way to cross-compile Go packages. Since Go1.5,
packages can be simply compiled by calling `GOOS=xx GOARCH=xx go build`.
Add MAINTAINERS.md
0e58bb4
moul
moul approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 25.295% when pulling 0e58bb4 on build-improvements into 6580156 on master.

@brmzkw brmzkw merged commit a3e8fe8 into master Apr 3, 2017
@brmzkw brmzkw removed the in progress label Apr 3, 2017
@brmzkw brmzkw deleted the build-improvements branch April 3, 2017 15:59
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
doc: Add new issues templates (scaleway#453)
658c844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moul moul moul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brmzkw @coveralls @moul