Skip to content

Conversation

@remyleone
Copy link
Member

@remyleone remyleone commented Apr 17, 2018

This is an answer to #446
This PR adds an example showing scw ps with a filter.

Should we use the --region flag passed before the command ps to filter the API on which the ps commands run upon?

@remyleone remyleone requested a review from moul April 17, 2018 13:11
Copy link
Contributor

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moul moul merged commit 2f6aabc into scaleway:master Apr 20, 2018
@moul moul removed the in progress label Apr 20, 2018
@remyleone
Copy link
Member Author

@moul What about the --region question? It seems that this questions come back often "region" tag issues.

@moul
Copy link
Contributor

moul commented Apr 20, 2018

Should we use the --region flag passed before the command ps to filter the API on which the ps commands run upon?

By default, I'm more for using this as a global variable as its (or will be) useful for the majority of the commands in scw.

But from what I recently saw, it's more and more standard to put every argument at the end of the command, probably "more POSIX," i.e., https://github.com/spf13/cobra

Keep in mind that the current scw API is based on docker's one which makes the distinction between global and command-specific flags

I suggest you vote with the rest of the team to choose a norm

@remyleone remyleone deleted the filter_regions branch May 20, 2020 13:46
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants