Skip to content

feat(instance): add field zone for PrivateNIC/PrivateNetwork #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+13 −8
Merged

feat(instance): add field zone for PrivateNIC/PrivateNetwork #5065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ require (
github.com/mattn/go-isatty v0.0.20
github.com/moby/buildkit v0.25.1
github.com/opencontainers/go-digest v1.0.0
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251015050748-12aafea99911
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251021155809-12b7dd9ad43c
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.10.1
github.com/spf13/pflag v1.0.10
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251015050748-12aafea99911 h1:puwRtGGoGw9Rw3qlB7ltimV2+uugkalN08DyVEL1VoE=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251015050748-12aafea99911/go.mod h1:SVm1Zk6UpZtqZN6KtEQpjC+v+Lir4tyVfhQTU19q3PA=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251021155809-12b7dd9ad43c h1:az3Va1xvp74kFDyeOmIncWIE3+I5lcNmzQhByailMiI=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.35.0.20251021155809-12b7dd9ad43c/go.mod h1:SVm1Zk6UpZtqZN6KtEQpjC+v+Lir4tyVfhQTU19q3PA=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=
Expand Down
4 changes: 3 additions & 1 deletion internal/namespaces/instance/v1/testdata/test-get-private-nic-get-from-id.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ PrivateNic.PrivateNetworkID 79ec26ef-4b48-4bd8-92e8-baf28aca6c5c
PrivateNic.MacAddress 02:00:00:1d:0c:7f
PrivateNic.State available
PrivateNic.CreationDate few seconds ago
PrivateNic.Zone fr-par-1
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
{
"private_nic": {
Expand All @@ -15,6 +16,7 @@ PrivateNic.CreationDate few seconds ago
"mac_address": "02:00:00:1d:0c:7f",
"state": "available",
"tags": [],
"creation_date": "1970-01-01T00:00:00.0Z"
"creation_date": "1970-01-01T00:00:00.0Z",
"zone": "fr-par-1"
}
}
4 changes: 3 additions & 1 deletion internal/namespaces/instance/v1/testdata/test-get-private-nic-get-from-mac-address.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ PrivateNic.PrivateNetworkID 787b1845-c662-4ca3-aa0d-a6702605e9b5
PrivateNic.MacAddress 02:00:00:19:4b:78
PrivateNic.State available
PrivateNic.CreationDate few seconds ago
PrivateNic.Zone fr-par-1
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
{
"private_nic": {
Expand All @@ -15,6 +16,7 @@ PrivateNic.CreationDate few seconds ago
"mac_address": "02:00:00:19:4b:78",
"state": "available",
"tags": [],
"creation_date": "1970-01-01T00:00:00.0Z"
"creation_date": "1970-01-01T00:00:00.0Z",
"zone": "fr-par-1"
}
}
7 changes: 4 additions & 3 deletions internal/namespaces/instance/v1/testdata/test-list-ni-cs-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
ID SERVER ID PRIVATE NETWORK ID MAC ADDRESS STATE TAGS CREATION DATE
7a019c23-e156-4cfe-b0b1-0d5a8638b5a5 2db4796b-8280-4626-9924-81c9fba992a8 c3fafb4e-9ab2-4965-9cf1-429c799558a1 02:00:00:1e:ec:17 available [] few seconds ago
ID SERVER ID PRIVATE NETWORK ID MAC ADDRESS STATE TAGS CREATION DATE ZONE
7a019c23-e156-4cfe-b0b1-0d5a8638b5a5 2db4796b-8280-4626-9924-81c9fba992a8 c3fafb4e-9ab2-4965-9cf1-429c799558a1 02:00:00:1e:ec:17 available [] few seconds ago fr-par-1
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
[
{
Expand All @@ -11,6 +11,7 @@ ID SERVER ID PRIV
"mac_address": "02:00:00:1e:ec:17",
"state": "available",
"tags": [],
"creation_date": "1970-01-01T00:00:00.0Z"
"creation_date": "1970-01-01T00:00:00.0Z",
"zone": "fr-par-1"
}
]
Loading