Add --config option for arbitrary config file #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Contributor
|
It would be great to add an unittest |
brmzkw
reviewed
Aug 27, 2018
pkg/cli/main.go
Outdated
| flag.CommandLine.Parse(rawArgs) | ||
|
|
||
| if *flConfig != "" { | ||
| os.Setenv("SCW_CONFIG_PATH", *flConfig) |
Contributor
There was a problem hiding this comment.
I think you should not set the environment variable here, but instead return a default if SCW_CONFIG_PATH is not set below in pkg/config/config.go.
houndci-bot
reviewed
Aug 27, 2018
pkg/config/config_test.go
Outdated
| Convey("Testing SaveConfig() with env variable", t, func() { | ||
| os.Setenv("SCW_CONFIG_PATH", "./config_testdata2") | ||
| rand_org := strconv.FormatInt(rand.Int63(), 16) | ||
| rand_token := strconv.FormatInt(rand.Int63(), 16) |
There was a problem hiding this comment.
don't use underscores in Go names; var rand_token should be randToken
pkg/config/config_test.go
Outdated
| func TestSave(t *testing.T) { | ||
| Convey("Testing SaveConfig() with env variable", t, func() { | ||
| os.Setenv("SCW_CONFIG_PATH", "./config_testdata2") | ||
| rand_org := strconv.FormatInt(rand.Int63(), 16) |
There was a problem hiding this comment.
don't use underscores in Go names; var rand_org should be randOrg
Author
|
I've cleaned up the commit history, and added the option to specify the orgID and token via env variables too |
SCW_API_TOKEN = your token to access the api SCW_API_ORGID = your organization ID to access the api
Author
|
Rebased against master |
Contributor
|
thanks! <3 |
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple commit to add the ability to use an arbitrary config file instead of
~/.scwrc