feature: cli s3 integration #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits integrate the logic for the `scw s3` commands. This is using the minio client, preconfigured for `nl-ams` and `fr-par` regions. The minio configuration directory is computed from the location of the .scwrc, creating a .scw directory at the same location. The case of two .scwrc in the same directory is manage by adding another directory layer inside .scw/, for example /home/toto/.scwrc-toto will create configuration files for minio under /home/toto/.scw/scwrc-toto/
This commits add the scaleway/mc vendor to the cli under vendor/minio/mc path.
Use kqueue for Darwin target
Unsetting env before home test to not get an error on the assertion
Removing go 1.5 and 1.6 tests, since the 'context' module for minio is missing
Closed
QuentinBrosse
added a commit
to QuentinBrosse/scaleway-cli
that referenced
this pull request
Sep 10, 2019
This reverts commit ea013f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrate the logic for the
scw s3commands. Thisis using the minio client, preconfigured for
nl-amsandfr-parregions.
The minio configuration directory is computed from the location
of the .scwrc, creating a .scw directory at the same location.
The case of two .scwrc in the same directory is manage by adding
another directory layer inside .scw/, for example
/home/toto/.scwrc-toto will create configuration files for minio
under /home/toto/.scw/scwrc-toto/
vendor/minio/mc is get from scaleway/mc, which modify a few the
minio client for our usage
Question mark: I'm removing the tests for go 1.5 and 1.6 in this PR,
mainly because there is too much missing in thoses version for
minio to compile