Skip to content

fix: update version file link #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2019
Merged

fix: update version file link #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45fff79
add idea to gitignore
Feb 6, 2019
201a512
update version URL
Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ profile.out
.DS_STORE
.vendor
/.vscode
/.idea

# Vim Swapfiles
[._]*.s[a-v][a-z]
Expand Down
4 changes: 2 additions & 2 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ There is a Archlinux community package (aka. "AUR" — Archlinux User Repositor

### Update VERSION file

From time to time, scaleway-cli makes a HTTP query to https://fr-1.storage.online.net/scaleway/scaleway-cli/VERSION to check if it is at the latest version available. This file needs to be updated.
From time to time, scaleway-cli makes a HTTP query to `https://scw-devtools.s3.nl-ams.scw.cloud/scw-cli-version` to check if it is at the latest version available. This file needs to be updated.

**PLEASE WAIT UNTIL THE HOMEBREW PULL REQUEST IS ACCEPTED BEFORE UPDATING THE VERSION FILE.**

Expand All @@ -59,7 +59,7 @@ From time to time, scaleway-cli makes a HTTP query to https://fr-1.storage.onlin
$> echo '42.8' > VERSION
$> s3cmd put VERSION s3://scaleway/scaleway-cli/VERSION --acl-public
# Ensure it's at the latest version
$> curl https://fr-1.storage.online.net/scaleway/scaleway-cli/VERSION
$> curl https://scw-devtools.s3.nl-ams.scw.cloud/scw-cli-version
# Should display "42.8".
```

Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func checkVersion() {
req := http.Client{
Timeout: 1 * time.Second,
}
resp, err := req.Get("https://fr-1.storage.online.net/scaleway/scaleway-cli/VERSION")
resp, err := req.Get("https://scw-devtools.s3.nl-ams.scw.cloud/scw-cli-version")
if resp != nil {
defer resp.Body.Close()
}
Expand Down