Skip to content

feat(instance): Add examples in all instances commands #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2020
Merged

feat(instance): Add examples in all instances commands #667

merged 2 commits into from
Feb 7, 2020

Conversation

@remyleone
Copy link
Member

@remyleone remyleone commented Feb 4, 2020

No description provided.

@remyleone remyleone self-assigned this Feb 4, 2020
@remyleone remyleone changed the title WIP feat(instance): Add examples in all instances commands feat(instance): Add examples in all instances commands Feb 7, 2020
kindermoumoute
kindermoumoute requested changes Feb 7, 2020
View reviewed changes
loicbourgois
loicbourgois suggested changes Feb 7, 2020
View reviewed changes
kindermoumoute
kindermoumoute approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loicbourgois
loicbourgois approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit fe63923 into v2 Feb 7, 2020
@remyleone remyleone deleted the APIGW-1775 branch February 7, 2020 15:00
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
chore(instance): remove disable_public_ip field (scaleway#667)
3899ad5
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

+1 more reviewer

@loicbourgois loicbourgois loicbourgois approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@remyleone remyleone

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remyleone @kindermoumoute @loicbourgois