refactor: add an option to disable telemetry in BootstrapConfig #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindermoumoute
requested changes
Feb 10, 2020
internal/core/bootstrap.go
Outdated
| if (!matomo.ForceTelemetry && !config.BuildInfo.IsRelease()) || | ||
| (meta.command == nil || meta.command.DisableTelemetry) || | ||
| !matomo.IsTelemetryEnabled() { | ||
| // - no valid command was executed |
Contributor
There was a problem hiding this comment.
no command was executed*
internal/core/bootstrap.go
Outdated
| // - no valid command was executed | ||
| // - telemetry is disabled on the ran command | ||
| // - telemetry is explicitly disable in bootstrap config | ||
| if !matomo.IsTelemetryEnabled() || |
Contributor
There was a problem hiding this comment.
this check should happen at the end because it will read the config file
internal/core/bootstrap.go
Outdated
| // If not a client will be automatically created by the CLI using Config, Env and flags see createClient(). | ||
| Client *scw.Client | ||
|
|
||
| // DisableTelemetry, if set to true this will disable telemetry report no matter what the config sent_telemetry is set to. |
Contributor
There was a problem hiding this comment.
send_telemetry (typo)
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.