Skip to content

feat(core): rm secret-key, access-key, org-id, zone global flags #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

feat(core): rm secret-key, access-key, org-id, zone global flags #686

merged 1 commit into from
Feb 11, 2020

Conversation

@QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Feb 11, 2020 •
edited
Loading

Internal Ticket: APIGW-1877

kindermoumoute
kindermoumoute approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit a036120 into scaleway:v2 Feb 11, 2020
@QuentinBrosse QuentinBrosse deleted the APIGW-1877 branch February 11, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuentinBrosse @kindermoumoute