feat(args): add support for empty slice un/marshahaling #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-quere
force-pushed
the
APIGW-1884
branch
from
a865fc0 to
4a0a64b
Compare
kindermoumoute
requested changes
Feb 12, 2020
internal/args/unmarshal.go
Outdated
| } | ||
|
|
||
| // Make sure index is a positive integer. | ||
| // We check if argNameWords[0] is an positive integer to handle cases like keys.0.value=12 |
internal/args/marshal_test.go
Outdated
| StringsPtr: []*string{}, | ||
| }, | ||
| expected: []string{ | ||
| "strings=none", |
Contributor
There was a problem hiding this comment.
Do we want to support this for non-pointer slices? This is equivalent to not writing the argument.
Contributor
Author
There was a problem hiding this comment.
not extactly the same
absent => []string(nil)
=none => []string{}
Contributor
There was a problem hiding this comment.
AFAIK we don't have any use case for this as we always handle []string(nil) == []string{} in our APIs
internal/args/unmarshal.go
Outdated
| // If type is a slice: | ||
| // We check if argNameWords[0] is an number to handle cases like keys.0.value=12 | ||
|
|
||
| // We handle special case where array=none creates an empty slice. |
Contributor
There was a problem hiding this comment.
nit: When array=none, creates an empty slice.
jerome-quere
force-pushed
the
APIGW-1884
branch
from
cea05ee to
b67553d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.