Skip to content

feat(instance): generate user-data commands #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2020
Merged

feat(instance): generate user-data commands #695

merged 2 commits into from
Feb 13, 2020

Conversation

@QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Feb 11, 2020 •
edited
Loading

No description provided.

loicbourgois
loicbourgois suggested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results of the different commands should be tested using goldens, instead of putting the results in the PR description.

@QuentinBrosse QuentinBrosse force-pushed the APIGW-1832 branch 2 times, most recently from 94c13a6 to e7f7326 Compare February 12, 2020 14:27
@QuentinBrosse QuentinBrosse changed the title feat(instance): generate user-data commands WIP: feat(instance): generate user-data commands Feb 12, 2020
golangcibot
golangcibot reviewed Feb 12, 2020
View reviewed changes
@QuentinBrosse QuentinBrosse force-pushed the APIGW-1832 branch 2 times, most recently from d642502 to 3d4fc81 Compare February 12, 2020 16:55
@QuentinBrosse QuentinBrosse changed the title WIP: feat(instance): generate user-data commands feat(instance): generate user-data commands Feb 13, 2020
kindermoumoute
kindermoumoute approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loicbourgois
loicbourgois approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 8ac53ae into scaleway:v2 Feb 13, 2020
@kindermoumoute kindermoumoute added this to the v2.0.0-alpha.1 milestone Feb 14, 2020
@QuentinBrosse QuentinBrosse deleted the APIGW-1832 branch February 19, 2020 14:40
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
fix(baremetal): fix error checking (scaleway#695)
d18abf1
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

+2 more reviewers

@golangcibot golangcibot golangcibot left review comments

@loicbourgois loicbourgois loicbourgois approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

v2.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

5 participants

@QuentinBrosse @kindermoumoute @loicbourgois @golangcibot @remyleone