feat(core): add Dockerfile and instructions #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 19, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
remyleone
reviewed
Mar 19, 2020
Co-Authored-By: Rémy Léone <remy.leone@gmail.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 19, 2020
loicbourgois
suggested changes
Mar 19, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
jerome-quere
previously requested changes
Mar 19, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Contributor
QuentinBrosse
left a comment
QuentinBrosse
left a comment
There was a problem hiding this comment.
Our README will become too big with all these details IMO.. :/
Maybe we should move this advancer configs in a dedicated file or simply provide image in docker hub right now?
Contributor
Author
|
@QuentinBrosse hmm it's still pretty small 🤔 |
kindermoumoute
requested changes
Mar 24, 2020
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
QuentinBrosse
suggested changes
Mar 24, 2020
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com