feat(eslint-config): harden eslint config

Author: chambo-e

package.json

@@ -33,7 +33,7 @@
     "@types/react-dom": "18.0.10",
     "builtin-modules": "3.3.0",
     "cross-env": "7.0.3",
-    "eslint": "8.31.0",
+    "eslint": "8.32.0",
     "husky": "8.0.3",
     "jest": "29.3.1",
     "jest-environment-jsdom": "29.3.1",

packages/eslint-config-react/package.json

@@ -25,16 +25,16 @@
     "eslint-config-prettier": "8.6.0",
     "eslint-plugin-deprecation": "1.3.3",
     "eslint-plugin-eslint-comments": "3.2.0",
-    "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jsx-a11y": "6.7.0",
-    "eslint-plugin-react": "7.31.11",
+    "eslint-plugin-import": "2.27.4",
+    "eslint-plugin-jsx-a11y": "6.7.1",
+    "eslint-plugin-react": "7.32.0",
     "eslint-plugin-react-hooks": "4.6.0"
   },
   "peerDependencies": {
     "eslint": ">= 8.5"
   },
   "devDependencies": {
-    "eslint": "8.31.0",
+    "eslint": "8.32.0",
     "typescript": "4.9.4"
   }
 }

packages/eslint-config-react/shared.js

@@ -98,6 +98,10 @@ module.exports = {
     'react/no-adjacent-inline-elements': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-adjacent-inline-elements.md
     'prefer-object-has-own': 'error', // https://eslint.org/docs/rules/prefer-object-has-own
 
+    // Prevent uneeded rerender with object as default props
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/c8f2813758dea1759ba5ab8caf1920cae9417a43/docs/rules/no-object-type-as-default-prop.md
+    'react/no-object-type-as-default-prop': 'error',
+
     // We don't use babel-preset-airbnb so we can make those changes
     'react/static-property-placement': ['error', 'static public field'],
     'react/state-in-constructor': ['error', 'never'],

packages/eslint-config-react/typescript.js

@@ -9,6 +9,26 @@ module.exports = {
   plugins: ['deprecation', '@typescript-eslint'],
   rules: {
     'deprecation/deprecation': 'warn',
+    // Enforce T[] instead of Array<T>
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
+    // Avoid toString which are going to generate [object Object]
+    '@typescript-eslint/no-base-to-string': 'error',
+    // (someCondition === true) => (someCondition)
+    '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+    '@typescript-eslint/no-unnecessary-condition': 'error',
+    '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+    '@typescript-eslint/no-unsafe-declaration-merging': 'error',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-includes': 'error',
+    '@typescript-eslint/prefer-optional-chain': 'error',
+    '@typescript-eslint/prefer-reduce-type-parameter': 'error',
+    '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+    '@typescript-eslint/prefer-ts-expect-error': 'error',
     // https://github.com/typescript-eslint/typescript-eslint/issues/4619
     '@typescript-eslint/no-misused-promises': [
       'error',