Skip to content

Conversation

@QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Oct 27, 2022

BREAKING CHANGE: Required generic for useI18n() / useTranslation.

When using useI18n() / useTranslation() without providing a generic for the locale, t and namespaceTranslation will throw an error (You must pass a generic argument to ****) to enforce the usage of a Locale.

@QuiiBz QuiiBz requested a review from chambo-e October 27, 2022 08:36
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1059 (d50439f) into main (294b256) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          23       23           
  Lines         584      584           
  Branches       80       80           
=======================================
  Hits          583      583           
  Partials        1        1           
Impacted Files Coverage Δ
packages/use-i18n/src/usei18n.tsx 98.92% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@QuiiBz QuiiBz merged commit e028640 into main Oct 27, 2022
@QuiiBz QuiiBz deleted the fix/required-generic-locale branch October 27, 2022 08:43
QuiiBz added a commit that referenced this pull request Oct 27, 2022
QuiiBz pushed a commit that referenced this pull request Oct 27, 2022
@QuiiBz QuiiBz restored the fix/required-generic-locale branch October 27, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants