Skip to content

feat(eslint-config-react): consistent import/no-extraneous-dependencies rule #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

feat(eslint-config-react): consistent import/no-extraneous-dependencies rule #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0765e5
feat(eslint-config-react): consistent import/no-extraneous-dependenci…
chambo-e Dec 16, 2022
c883702
fix: remove duplicat rule
chambo-e Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@
"browser": true,
"jest": true
},
"rules": {
"import/no-extraneous-dependencies": [
"error",
{
"devDependencies": ["**/__tests__/*", "rollup.config.mjs"]
}
]
},
"overrides": [
{
"parser": "@babel/eslint-parser",
Expand Down
27 changes: 27 additions & 0 deletions packages/eslint-config-react/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,33 @@ module.exports = {
'newlines-between': 'never',
},
],
// Here we override airbnb default with our repos dev patterns
// https://github.com/airbnb/javascript/blob/81157eec2309449b31f36bf8940493623f2530c6/packages/eslint-config-airbnb-base/rules/imports.js#L71
'import/no-extraneous-dependencies': [
'error',
{
devDependencies: [
'**/.jest/**',
'**/.storybook/**',
'test/**', // tape, common npm pattern
'tests/**', // also common npm pattern
'spec/**', // mocha, rspec-like pattern
'**/__tests__/**', // jest pattern
'**/__mocks__/**', // jest pattern
'**/__stories__/**', // stories pattern
'test.{js,jsx}', // repos with a single test file
'test-*.{js,jsx}', // repos with multiple top-level test files
'**/*{.,_}{test,spec}.{js,jsx}', // tests where the extension or filename suffix denotes that it is a test
'**/jest.config.{js,ts,mjs,mts}', // jest config
'**/jest.setup.{js,ts,mjs,mts}', // jest setup
'**/webpack.config.{js,ts,mjs,mts}', // webpack config
'**/webpack.config.*.{js,ts,mjs,mts}', // webpack config
'**/rollup.config.{js,ts,mjs,mts}', // rollup config
'**/rollup.config.*.{js,ts,mjs,mts}', // rollup config
],
optionalDependencies: false,
},
],
// We allow named and default export
'import/prefer-default-export': 'off',
// This allows us to reenable ForOfStatement.
Expand Down