Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/use-dataloader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
"directory": "packages/use-dataloader"
},
"license": "MIT",
"dependencies": {
"prop-types": "15.8.1"
},
"peerDependencies": {
"react": "18.x"
}
Expand Down
34 changes: 11 additions & 23 deletions packages/use-dataloader/src/DataLoaderProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import PropTypes from 'prop-types'
import type { ReactElement, ReactNode } from 'react'
import { createContext, useCallback, useContext, useMemo, useRef } from 'react'
import {
Expand Down Expand Up @@ -56,17 +55,19 @@ export type IDataLoaderContext = {
// @ts-expect-error we force the context to undefined, should be corrected with default values
export const DataLoaderContext = createContext<IDataLoaderContext>(undefined)

type DataLoaderProviderProps = {
children: ReactNode
cacheKeyPrefix?: string
onError?: OnErrorFn
maxConcurrentRequests?: number
}

const DataLoaderProvider = ({
children,
cacheKeyPrefix,
cacheKeyPrefix = '',
onError,
maxConcurrentRequests,
}: {
children: ReactNode
cacheKeyPrefix: string
onError: OnErrorFn
maxConcurrentRequests?: number
}): ReactElement => {
maxConcurrentRequests = DEFAULT_MAX_CONCURRENT_REQUESTS,
}: DataLoaderProviderProps): ReactElement => {
const requestsRef = useRef<Requests>({})

const computeKey = useCallback(
Expand All @@ -82,7 +83,7 @@ const DataLoaderProvider = ({
const addRequest = useCallback(
(key: string, args: UseDataLoaderInitializerArgs) => {
if (DataLoader.maxConcurrent !== maxConcurrentRequests) {
DataLoader.maxConcurrent = maxConcurrentRequests as number
DataLoader.maxConcurrent = maxConcurrentRequests
}
if (key && typeof key === 'string') {
const newRequest = new DataLoader({
Expand Down Expand Up @@ -212,19 +213,6 @@ const DataLoaderProvider = ({
)
}

DataLoaderProvider.propTypes = {
cacheKeyPrefix: PropTypes.string,
children: PropTypes.node.isRequired,
maxConcurrentRequests: PropTypes.number,
onError: PropTypes.func,
}

DataLoaderProvider.defaultProps = {
cacheKeyPrefix: undefined,
maxConcurrentRequests: DEFAULT_MAX_CONCURRENT_REQUESTS,
onError: undefined,
}

export const useDataLoaderContext = (): IDataLoaderContext =>
useContext(DataLoaderContext)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const initialProps = {
}),
),
}
// eslint-disable-next-line react/prop-types
const wrapper = ({ children }: { children?: ReactNode }) => (
<DataLoaderProvider>{children}</DataLoaderProvider>
)
Expand Down
3 changes: 1 addition & 2 deletions packages/use-i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"date-fns": "2.29.3",
"filesize": "10.0.6",
"international-types": "0.3.6",
"intl-messageformat": "10.2.5",
"prop-types": "15.8.1"
"intl-messageformat": "10.2.5"
},
"peerDependencies": {
"date-fns": "2.x",
Expand Down
14 changes: 0 additions & 14 deletions packages/use-i18n/src/usei18n.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import type { NumberFormatOptions } from '@formatjs/ecma402-abstract'
import type { Locale as DateFnsLocale } from 'date-fns'
import { formatDistanceToNow, formatDistanceToNowStrict } from 'date-fns'
import type { BaseLocale } from 'international-types'
import PropTypes from 'prop-types'
import type { ReactElement, ReactNode } from 'react'
import {
createContext,
Expand Down Expand Up @@ -397,17 +396,4 @@ const I18nContextProvider = ({
return <I18nContext.Provider value={value}>{children}</I18nContext.Provider>
}

I18nContextProvider.propTypes = {
children: PropTypes.node.isRequired,
defaultDateLocale: PropTypes.shape({}),
defaultLoad: PropTypes.func.isRequired,
defaultLocale: PropTypes.string.isRequired,
defaultTranslations: PropTypes.shape({}),
enableDebugKey: PropTypes.bool,
enableDefaultLocale: PropTypes.bool,
loadDateLocale: PropTypes.func,
localeItemStorage: PropTypes.string,
supportedLocales: PropTypes.arrayOf(PropTypes.string).isRequired,
}

export default I18nContextProvider
7 changes: 1 addition & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.