Skip to content

Conversation

@chambo-e
Copy link
Contributor

Prerequisite for #1157

@chambo-e chambo-e requested a review from a team January 13, 2023 10:01
@chambo-e chambo-e self-assigned this Jan 13, 2023
@chambo-e chambo-e requested review from matthprost and vincentaudebert and removed request for a team January 13, 2023 10:01
@chambo-e
Copy link
Contributor Author

Might need formatjs/formatjs#3964

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #1158 (eb0bd72) into main (9d6de7b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          24       24           
  Lines         628      630    +2     
  Branches       91       90    -1     
=======================================
+ Hits          622      624    +2     
  Partials        6        6           
Impacted Files Coverage Δ
packages/random-name/src/index.ts 100.00% <ø> (ø)
packages/use-dataloader/src/helpers.ts 100.00% <ø> (ø)
packages/use-dataloader/src/useDataLoader.ts 100.00% <ø> (ø)
packages/use-i18n/src/formatters.ts 100.00% <ø> (ø)
packages/use-query-params/src/index.ts 100.00% <ø> (ø)
packages/use-dataloader/src/DataLoaderProvider.tsx 100.00% <100.00%> (ø)
packages/use-dataloader/src/dataloader.ts 100.00% <100.00%> (ø)
packages/use-gtm/src/scripts.ts 100.00% <100.00%> (ø)
packages/use-gtm/src/useGTM.tsx 100.00% <100.00%> (ø)
packages/use-i18n/src/formatUnit.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chambo-e chambo-e merged commit 7e2130e into main Jan 13, 2023
@chambo-e chambo-e deleted the feat/harden_type branch January 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants