Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-items-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@scaleway/changesets-renovate': minor
---

Ignore changes in workspace's root package.json
33 changes: 33 additions & 0 deletions packages/changesets-renovate/src/__tests__/generate-changeset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,37 @@ describe('generate changeset file', () => {
})
expect(push).toHaveBeenCalledWith(['--force'])
})

it('should ignore workspace package.json', async () => {
const file = 'package.json'

// @ts-expect-error we mock at the top
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
simpleGit.mockReturnValue({
branch: () => ({
current: 'renovate/test',
}),
diffSummary: () => ({
files: [
{
file,
},
],
}),
show: () => `
+ "package": "version"
+ "package2": "version2"
`,
})

fs.readFile = jest
.fn()
.mockResolvedValue(`{"name":"packageName","workspaces":[]}`)
fs.writeFile = jest.fn()

await run()

expect(fs.readFile).toHaveBeenCalledWith(file, 'utf8')
expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
})
})
18 changes: 16 additions & 2 deletions packages/changesets-renovate/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,22 @@ import fs from 'node:fs/promises'
import { simpleGit } from 'simple-git'

async function getPackagesNames(files: string[]): Promise<string[]> {
const packages: string[] = []

const promises = files.map(async file => {
const data = JSON.parse(await fs.readFile(file, 'utf8')) as {
name: string
workspaces?: string[]
}

return data.name
if (!data.workspaces) {
packages.push(data.name)
}
})

return Promise.all(promises)
await Promise.all(promises)

return packages
}

async function createChangeset(
Expand Down Expand Up @@ -84,6 +91,13 @@ export async function run() {
}

const packageNames = await getPackagesNames(files)

if (packageNames.length === 0) {
console.log('No packages modified, skipping')

return
}

const shortHash = await simpleGit().revparse(['--short', 'HEAD'])
const fileName = `.changeset/renovate-${shortHash.trim()}.md`
const packageBumps = await getBumps(files)
Expand Down