Skip to content

fix: enableDebugKey display key #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix: enableDebugKey display key #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
331f13f
fix: enableDebugKey display key
DorianMaliszewski Apr 6, 2023
aafc6a8
fix: changeset
DorianMaliszewski Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-turtles-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@scaleway/use-i18n': minor
---

enableDebugKey should always return the key
16 changes: 5 additions & 11 deletions packages/use-i18n/src/__tests__/usei18n.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,17 +297,11 @@ describe('i18n hook', () => {
expect(result.current.t('test')).toEqual('test')

await waitFor(() => {
expect(result.current.t('title')).toEqual(en.title)
expect(result.current.t('subtitle')).toEqual(en.subtitle)
expect(result.current.t('plurals', { numPhotos: 0 })).toEqual(
'You have no photos.',
)
expect(result.current.t('plurals', { numPhotos: 1 })).toEqual(
'You have one photo.',
)
expect(result.current.t('plurals', { numPhotos: 2 })).toEqual(
'You have 2 photos.',
)
expect(result.current.t('title')).toEqual('title')
expect(result.current.t('subtitle')).toEqual('subtitle')
expect(result.current.t('plurals', { numPhotos: 0 })).toEqual('plurals')
expect(result.current.t('plurals', { numPhotos: 1 })).toEqual('plurals')
expect(result.current.t('plurals', { numPhotos: 2 })).toEqual('plurals')
})
})

Expand Down
8 changes: 4 additions & 4 deletions packages/use-i18n/src/usei18n.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,11 @@ const I18nContextProvider = ({
const translate = useCallback(
(key: string, context?: ReactParamsObject<any>) => {
const value = translations[currentLocale]?.[key] as string
if (!value) {
if (enableDebugKey) {
return key
}
if (enableDebugKey) {
return key
}

if (!value) {
return ''
}
if (context) {
Expand Down