Skip to content

Conversation

@ModuloM
Copy link
Contributor

@ModuloM ModuloM commented May 19, 2023

Verify that the provider renders client side before checking locale from either navigator or localSotrage.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 537a88b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-i18n Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1320 (37376e7) into main (34a3305) will decrease coverage by 0.30%.
The diff coverage is 71.42%.

❗ Current head 37376e7 differs from pull request most recent head 537a88b. Consider uploading reports for the commit 537a88b to get more accurate results

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   98.94%   98.65%   -0.30%     
==========================================
  Files          24       24              
  Lines         666      668       +2     
  Branches       94       95       +1     
==========================================
  Hits          659      659              
- Misses          0        1       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
packages/use-i18n/src/usei18n.tsx 96.87% <71.42%> (-2.07%) ⬇️

@ModuloM ModuloM requested review from QuiiBz and philibea May 22, 2023 08:47
@ModuloM ModuloM self-assigned this May 22, 2023
@ModuloM ModuloM added the enhancement New feature or request label May 22, 2023
@ModuloM ModuloM force-pushed the feat/use-i18n-server-side branch 2 times, most recently from bc11e6b to 37376e7 Compare May 22, 2023 13:16
@ModuloM ModuloM force-pushed the feat/use-i18n-server-side branch from 37376e7 to 537a88b Compare May 23, 2023 14:59
@ModuloM ModuloM merged commit 8da6d75 into main May 23, 2023
@ModuloM ModuloM deleted the feat/use-i18n-server-side branch May 23, 2023 15:31
@github-actions github-actions bot mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants