fix(formatUnit): allow to change base on formatUnit #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c369f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vincentaudebert
force-pushed
the
fix/format-unit
branch
from
fd47984 to
39d7507
Compare
Codecov Report
@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 24 24
Lines 669 669
Branches 95 95
=======================================
Hits 660 660
Misses 1 1
Partials 8 8
|
QuiiBz
approved these changes
Jul 26, 2023
philibea
reviewed
Jul 26, 2023
chambo-e
approved these changes
Jul 26, 2023
vincentaudebert
force-pushed
the
fix/format-unit
branch
from
71cf890 to
329b9d6
Compare
vincentaudebert
force-pushed
the
fix/format-unit
branch
from
329b9d6 to
0c369f5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify a base (other than 10) on formatUnit function.
This way 4294967296 can format to 4 GB for example.