feat(growthbook): add new package to mutualise GrowthBook init #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5fa51b2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Slashgear
force-pushed
the
ab-test-tool
branch
2 times, most recently
from
b2e3fc4 to
6e672d6
Compare
Collaborator
|
@Slashgear missing some file inside the package:
|
philibea
reviewed
Jul 31, 2023
Slashgear
changed the title
Collaborator
|
@Slashgear missing some test ? |
Contributor
Author
|
@philibea Just added some test :) |
chambo-e
reviewed
Aug 1, 2023
chambo-e
approved these changes
Aug 3, 2023
QuiiBz
approved these changes
Aug 3, 2023
philibea
approved these changes
Aug 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #1416 +/- ##
==========================================
+ Coverage 98.65% 98.69% +0.03%
==========================================
Files 24 26 +2
Lines 669 688 +19
Branches 95 97 +2
==========================================
+ Hits 660 679 +19
Misses 1 1
Partials 8 8
|
Slashgear
force-pushed
the
ab-test-tool
branch
2 times, most recently
from
f41fc10 to
ed4906c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to add AB test and feature flag frontend tools to many projects at scaleway.
In order to lever what have been done in Console project, I propose to extract the
initof AB test in a dedicate package which has the responsability and API of it.For now, Growthbook is used but this package allow to change it or to enhance/adapt it to our usage and share it within the company.
How