Skip to content

Conversation

@Slashgear
Copy link
Contributor

Why

The changeset I wrote in my PR refer to incorrect name of package before review was applied.
This make the release job fail on main branch. See here https://github.com/scaleway/scaleway-lib/actions/runs/5782763966

How

  • change name of changeset file starting with pr
  • change the name of the declared package to match existing one

@Slashgear Slashgear requested review from QuiiBz and philibea August 7, 2023 09:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

⚠️ No Changeset found

Latest commit: adafbc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-growthbook Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1434 (adafbc5) into main (c726608) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          26       26           
  Lines         688      688           
  Branches       97       97           
=======================================
  Hits          679      679           
  Misses          1        1           
  Partials        8        8           

@philibea philibea merged commit 4695cbc into scaleway:main Aug 7, 2023
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants