Skip to content

Conversation

@QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Aug 17, 2023

Not sure why there is an OOM when running eslint but not when running tsc.

// Before
export type ScopedValue<Locale extends BaseLocale, Scope extends Scopes<Locale> | undefined, Key extends LocaleKeys<Locale, Scope>> = Scope extends undefined ? IsPlural<Key, Locale> extends true ? Locale[`${Key}#${PluralSuffix}`] : Locale[Key] : IsPlural<Key, Locale> extends true ? Locale[`${Scope}.${Key}#${PluralSuffix}`] : Locale[`${Scope}.${Key}`];

// After
export type ScopedValue<Locale extends BaseLocale, Scope extends Scopes<Locale> | undefined, Key extends LocaleKeys<Locale, Scope>> = Scope extends undefined ? Locale[Key] : Locale[`${Scope}.${Key}`];

@QuiiBz QuiiBz added the bug Something isn't working label Aug 17, 2023
@QuiiBz QuiiBz requested review from chambo-e and philibea August 17, 2023 08:35
@QuiiBz QuiiBz self-assigned this Aug 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: c6d0a15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-i18n Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1461 (c6d0a15) into main (4f9c7d3) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          26       26           
  Lines         689      689           
  Branches       97       97           
=======================================
  Hits          680      680           
  Misses          1        1           
  Partials        8        8           

@QuiiBz QuiiBz merged commit 4e4e639 into main Aug 17, 2023
@QuiiBz QuiiBz deleted the fix/i18n-oom branch August 17, 2023 08:45
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants