Skip to content

Conversation

@Axel-KIRK
Copy link
Contributor

@Axel-KIRK Axel-KIRK commented Sep 1, 2023

What

  • Extract internal cookie consent provider strategy to shared package

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 58abc3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/cookie-consent Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (7d38f6f) 98.73% compared to head (beda660) 98.86%.

❗ Current head beda660 differs from pull request most recent head 58abc3d. Consider uploading reports for the commit 58abc3d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   98.73%   98.86%   +0.13%     
==========================================
  Files          26       30       +4     
  Lines         709      792      +83     
  Branches      105      113       +8     
==========================================
+ Hits          700      783      +83     
  Misses          1        1              
  Partials        8        8              
Files Changed Coverage Δ
...rc/CookieConsentProvider/CookieConsentProvider.tsx 100.00% <100.00%> (ø)
...rc/CookieConsentProvider/useSegmentIntegrations.ts 100.00% <100.00%> (ø)
packages/cookie-consent/src/helpers/array.ts 100.00% <100.00%> (ø)
packages/cookie-consent/src/helpers/misc.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Axel-KIRK Axel-KIRK force-pushed the test-branch branch 2 times, most recently from 98694a9 to 248e731 Compare September 20, 2023 10:11
Copy link
Contributor

@Vinzius Vinzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Team, for tackling this task ^^

@Slashgear Slashgear requested review from QuiiBz and Vinzius September 21, 2023 12:29
@Slashgear Slashgear enabled auto-merge (squash) September 25, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants