Skip to content

Conversation

@DorianMaliszewski
Copy link
Member

Change the way that we handle data, based now on the cache directly.

It implies that :

  • DataProvider is our source of trust
  • User will never cant use this hook without key
  • The hook is not responsible of the data

@DorianMaliszewski DorianMaliszewski added bug Something isn't working enhancement New feature or request labels May 3, 2021
@DorianMaliszewski DorianMaliszewski self-assigned this May 3, 2021
@DorianMaliszewski DorianMaliszewski changed the title fix: it should be good with key changing fix: let DataLoaderProvider handle data return from useDataLoader May 3, 2021
@DorianMaliszewski DorianMaliszewski force-pushed the fix/bad-async-use-dataloader branch 2 times, most recently from 13e19d1 to 9c92135 Compare May 4, 2021 07:54
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #150 (ecd4623) into master (2debbb0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          269       265    -4     
  Branches        42        41    -1     
=========================================
- Hits           269       265    -4     
Impacted Files Coverage Δ
packages/use-dataloader/src/reducer.js 100.00% <ø> (ø)
packages/use-dataloader/src/useDataLoader.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2debbb0...ecd4623. Read the comment docs.

@DorianMaliszewski DorianMaliszewski force-pushed the fix/bad-async-use-dataloader branch from 9c92135 to ecd4623 Compare May 4, 2021 12:21
@DorianMaliszewski DorianMaliszewski merged commit acd938f into master May 4, 2021
@DorianMaliszewski DorianMaliszewski deleted the fix/bad-async-use-dataloader branch May 4, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants