Skip to content

Conversation

@Slashgear
Copy link
Contributor

Why

I face missing exported types from the provider in order to easily declare them.
We could counter by getting them from AbTestProvider.

How

  • export two types from callback

@Slashgear Slashgear requested a review from philibea September 14, 2023 13:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: f35fcf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-growthbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Slashgear Slashgear requested a review from QuiiBz September 14, 2023 13:22
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e841e13) 98.69% compared to head (f35fcf5) 98.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          26       26           
  Lines         692      692           
  Branches       97       97           
=======================================
  Hits          683      683           
  Misses          1        1           
  Partials        8        8           
Files Changed Coverage Δ
packages/use-growthbook/src/AbTestProvider.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Slashgear Slashgear merged commit ca2aa68 into main Sep 15, 2023
@Slashgear Slashgear deleted the growthbook-type-export branch September 15, 2023 09:35
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants