Skip to content

feat(cookie-consent): pass cookie options when deleting one consent #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat(cookie-consent): pass cookie options when deleting one consent #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f244998
feat(cookie-consent): pass cookie options when deleting one consent
rachidBensaid Oct 5, 2023
9d1faab
feat(cookie-consent): add test
rachidBensaid Oct 5, 2023
797cc41
feat: update test to fix conflict
rachidBensaid Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-camels-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@scaleway/cookie-consent': patch
---

Pass cookie options when removing consent for a specific category
1 change: 1 addition & 0 deletions packages/cookie-consent/src/CookieConsentProvider/CookieConsentProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ export const CookieConsentProvider = ({
if (!consentValue) {
// If consent is set to false we have to delete the cookie
document.cookie = cookie.serialize(cookieName, '', {
...cookiesOptions,
expires: new Date(0),
})
} else {
Expand Down
6 changes: 2 additions & 4 deletions packages/cookie-consent/src/CookieConsentProvider/__tests__/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,16 @@ describe('CookieConsent - CookieConsentProvider', () => {
})
})

const cookieOptions = { sameSite: 'strict', secure: true }
const cookieOptions = { sameSite: 'strict', secure: true, path: '/' }

expect(spy).toHaveBeenCalledTimes(3)
expect(spy).toHaveBeenNthCalledWith(2, '_scw_rgpd_marketing', 'true', {
...cookieOptions,
maxAge: 33696000,
path: '/',
})
expect(spy).toHaveBeenNthCalledWith(3, '_scw_rgpd_hash', '913003917', {
...cookieOptions,
maxAge: 15552000,
path: '/',
})

act(() => {
Expand All @@ -172,12 +170,12 @@ describe('CookieConsent - CookieConsentProvider', () => {

expect(spy).toHaveBeenCalledTimes(6)
expect(spy).toHaveBeenNthCalledWith(5, '_scw_rgpd_marketing', '', {
...cookieOptions,
expires: new Date(0),
})
expect(spy).toHaveBeenNthCalledWith(6, '_scw_rgpd_hash', '913003917', {
...cookieOptions,
maxAge: 15552000,
path: '/',
})
})

Expand Down