Skip to content

fix(cookies): keep special condition for google ads #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2023
Merged

fix(cookies): keep special condition for google ads #1562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
756b4c7
fix(cookies): keep special condition for google ads
Vinzius Oct 9, 2023
0611e86
docs: add comment
Vinzius Oct 9, 2023
340e3c6
docs: improve comment
Vinzius Oct 9, 2023
698927b
chore: changeset
Vinzius Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-peaches-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@scaleway/cookie-consent': patch
---

keep special condition for google ads
5 changes: 3 additions & 2 deletions packages/cookie-consent/src/CookieConsentProvider/useSegmentIntegrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ const transformSegmentIntegrationsToIntegrations = (
segmentIntegrations: SegmentIntegrations,
): Integrations =>
[defaultSegmentIoIntegration, ...segmentIntegrations].map(
({ category, name }) => ({
name,
({ category, creationName, name }) => ({
// Segment requires the `creationName` for this destination.
name: name === 'Google Ads (Gtag)' ? creationName : name,
category: CATEGORY_MATCH[category] ?? 'marketing',
}),
)
Expand Down