Skip to content

Conversation

@Slashgear
Copy link
Contributor

Why

Some links are broken in the global readme of the repository

  • bundlephobia pages are not working because package does not export entrypoints
  • they are broken links in growthbook package

How

  • fix global readme links
  • re-add main entry to make bundlephobia working

@QuiiBz What is your opinion on re-adding main key on package ?

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: 75aaa72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31f9adc) 98.49% compared to head (75aaa72) 98.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1599   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          30       30           
  Lines         797      797           
  Branches      115      115           
=======================================
  Hits          785      785           
  Misses          2        2           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Slashgear Slashgear requested a review from QuiiBz October 23, 2023 11:58
Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't (and don't) need the main field in each package.json, since we're using the "new" exports field instead which covers all our needs.

It's probably a bug (or at least an unsupported feature) of bundlephobia to not support the exports field - example with packagephobia, which supports it fine: https://packagephobia.com/result?p=%40scaleway%2Fjest-helpers

@Slashgear
Copy link
Contributor Author

Ok I will change that

@Slashgear Slashgear merged commit a9bd06f into main Oct 24, 2023
@Slashgear Slashgear deleted the fix-docs-typo branch October 24, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants