Skip to content

Conversation

@philibea
Copy link
Collaborator

@philibea philibea commented Nov 26, 2023

Migration from "tsd-lite" to "tstyche".

waiting tstyche/tstyche#17

close #1658

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2023

⚠️ No Changeset found

Latest commit: da372b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (8b0b136) to head (e23dfe4).
Report is 79 commits behind head on main.

❗ Current head e23dfe4 differs from pull request most recent head da372b6. Consider uploading reports for the commit da372b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   97.59%   98.49%   +0.89%     
==========================================
  Files          30       30              
  Lines         833      797      -36     
  Branches      124      115       -9     
==========================================
- Hits          813      785      -28     
+ Misses          7        2       -5     
+ Partials       13       10       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philibea philibea force-pushed the use-new-typecheck-test branch from e472f80 to cafd9c7 Compare November 27, 2023 08:13
@philibea philibea self-assigned this Nov 27, 2023
@philibea philibea added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 27, 2023
@philibea
Copy link
Collaborator Author

Waiting tstyche/tstyche#17

@philibea philibea force-pushed the use-new-typecheck-test branch from cafd9c7 to e23dfe4 Compare December 11, 2023 11:26
@mrazauskas
Copy link
Contributor

mrazauskas commented Jan 23, 2024

Thanks for giving TSTyche a try. I was wondering why did you marked this PR as blocked by tstyche/tstyche#17?

In a way current tstyche matchers can be used as their tsd equivalents. I agreed that .not.toBeCallable() would be perfect here. Just trying to say that it also can be adopted gradually some time later. .toBeCallable() will take time to get implement. I will make it work, but this is rather involving.

It was good idea to wait a bit, of course. TSTyche became more performant, because the latest release by default will load typescript package from your the repo. This is big improvement, because, as you know, jest-runner-tsd requires @tsd/typescript to be installed additionally.

I was simply curious to see how TSTyche will work with pnpm. Hoping to convince you to migrate soon (; Let me know, if there is anything I can help.

@philibea philibea force-pushed the use-new-typecheck-test branch from e23dfe4 to 052c750 Compare April 1, 2024 22:24
@philibea philibea force-pushed the use-new-typecheck-test branch from 052c750 to c008260 Compare April 1, 2024 22:35
@philibea philibea force-pushed the use-new-typecheck-test branch from 7ef4594 to da372b6 Compare April 1, 2024 22:43
@philibea philibea marked this pull request as ready for review April 1, 2024 22:44
@philibea philibea merged commit da3f398 into main Apr 1, 2024
@philibea philibea deleted the use-new-typecheck-test branch April 1, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants