fix(useSegment): add ready state #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d36ebcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
philibea
reviewed
Dec 12, 2023
ModuloM
force-pushed
the
fix/use-segment-ready
branch
4 times, most recently
from
424f8ea to
c88445f
Compare
ModuloM
force-pushed
the
fix/use-segment-ready
branch
from
e33aa63 to
066d8ea
Compare
BABAK0T0
approved these changes
Dec 13, 2023
JulienSaguez
approved these changes
Dec 13, 2023
ModuloM
force-pushed
the
fix/use-segment-ready
branch
from
066d8ea to
53a1828
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 98.49% 98.51% +0.01%
==========================================
Files 30 30
Lines 798 807 +9
Branches 116 119 +3
==========================================
+ Hits 786 795 +9
Misses 2 2
Partials 10 10 ☔ View full report in Codecov by Sentry. |
philibea
reviewed
Dec 18, 2023
philibea
reviewed
Dec 18, 2023
philibea
reviewed
Dec 18, 2023
ModuloM
force-pushed
the
fix/use-segment-ready
branch
from
def56de to
73ca940
Compare
ModuloM
force-pushed
the
fix/use-segment-ready
branch
3 times, most recently
from
f9c64d7 to
c5a6e9c
Compare
ModuloM
force-pushed
the
fix/use-segment-ready
branch
from
c5a6e9c to
0c56e6a
Compare
philibea
approved these changes
Dec 22, 2023
ModuloM
force-pushed
the
fix/use-segment-ready
branch
from
9b73b93 to
a5a54f2
Compare
Co-authored-by: philibeaux <aphilibeaux@scaleway.com>
philibea
force-pushed
the
fix/use-segment-ready
branch
from
a5a54f2 to
d36ebcc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ready state to prevent calling events from Provider when analytics instance is not ready