feat(useCookieConsent): add isSegmentLoading state #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06264cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ModuloM
requested review from
DorianMaliszewski,
alexandre-combemorel and
philibea
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 30 30
Lines 798 798
Branches 116 116
=======================================
Hits 786 786
Misses 2 2
Partials 10 10 ☔ View full report in Codecov by Sentry. |
ModuloM
force-pushed
the
feat/cookie-consent-segment-loading
branch
2 times, most recently
from
3bd6cc8 to
5504c67
Compare
BABAK0T0
approved these changes
Dec 13, 2023
philibea
reviewed
Dec 13, 2023
packages/cookie-consent/src/CookieConsentProvider/useSegmentIntegrations.ts
Outdated
Show resolved
Hide resolved
ModuloM
force-pushed
the
feat/cookie-consent-segment-loading
branch
from
cc0c89b to
5c778d8
Compare
philibea
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add isSegmentLoading to be able to know when segment has not finished fetching integrations.