Skip to content

fix(useCookieConsent): fix missing dependency #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix(useCookieConsent): fix missing dependency #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-knives-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@scaleway/cookie-consent': patch
---

fix(useCookieConsent): fix missing dependency
2 changes: 1 addition & 1 deletion packages/use-segment/src/useSegment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function SegmentProvider<T extends Events>({
// When user has refused tracking, set ready anyway
setIsAnalyticsReady(true)
}
}, [onError, settings, initOptions, shouldLoad])
}, [onError, settings, initOptions, shouldLoad, areOptionsLoaded])

const value = useMemo<SegmentContextInterface<T>>(() => {
const curiedEvents = Object.entries(events).reduce(
Expand Down