fix(random-name): add xavier niel for consistency with scaleway-sdk-go #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8074869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 30 30
Lines 833 833
Branches 124 124
=======================================
Hits 813 813
Misses 7 7
Partials 13 13 ☔ View full report in Codecov by Sentry. |
philibea
force-pushed
the
fix/random-name-add-xavier-niel-for-consistency
branch
from
e479685 to
8074869
Compare
philibea
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a random name for a resource, we have a different standard between the go SDK and scaleway-lib. Specifically, scaleway-lib is missing Xavier Niel as a possible generated name.
This MR fixes it 🤓
Reference: https://github.com/scaleway/scaleway-sdk-go/blob/master/namegenerator/name_generator.go#L632