Skip to content

Conversation

@Slashgear
Copy link
Contributor

Why

Some of our apps are not yet compatible with esm natively and can't use the module exported files on server.
In order to to recompile them locally and as they are exported directly, let's add the legacy main attribute for retrocompatibility.

Recent package will use exports syntax and ignore the main one

How

  • add main on package that have CommonJS exported assets

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 8b568c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@scaleway/validate-icu-locales Minor
@scaleway/cookie-consent Major
@scaleway/use-dataloader Minor
@scaleway/use-growthbook Minor
@scaleway/random-name Minor
@scaleway/use-segment Minor
@scaleway/use-storage Minor
@scaleway/regex Minor
@scaleway/use-random-name Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@philibea philibea self-requested a review April 30, 2024 08:44
@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (e034a76) to head (8b568c1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1960   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files          25       25           
  Lines         753      753           
  Branches       94       94           
=======================================
  Hits          580      580           
  Misses        164      164           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atissedrescaleway atissedrescaleway self-requested a review April 30, 2024 11:45
@Slashgear Slashgear added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 30, 2024
@Slashgear Slashgear added this pull request to the merge queue May 2, 2024
@philibea philibea removed this pull request from the merge queue due to a manual request May 2, 2024
@philibea philibea merged commit d034b3c into main May 2, 2024
@philibea philibea deleted the use-main-compatibility branch May 2, 2024 07:29
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants