Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions packages/use-dataloader/src/DataLoaderProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import React, {

export const DataLoaderContext = createContext()

const DataLoaderProvider = ({ children }) => {
const DataLoaderProvider = ({ children, cacheKeyPrefix }) => {
const cachedData = useRef({})
const reloads = useRef({})

Expand All @@ -34,11 +34,11 @@ const DataLoaderProvider = ({ children }) => {
if (key && typeof key === 'string' && newData) {
setCachedData(actualCachedData => ({
...actualCachedData,
[key]: newData,
[`${cacheKeyPrefix ? `${cacheKeyPrefix}-` : ''}${key}`]: newData,
}))
}
},
[setCachedData],
[setCachedData, cacheKeyPrefix],
)

const addReload = useCallback(
Expand Down Expand Up @@ -76,13 +76,13 @@ const DataLoaderProvider = ({ children }) => {
if (key && typeof key === 'string') {
setCachedData(actualCachedData => {
const tmp = actualCachedData
delete tmp[key]
delete tmp[`${cacheKeyPrefix ? `${cacheKeyPrefix}-` : ''}${key}`]

return tmp
})
}
},
[setCachedData],
[setCachedData, cacheKeyPrefix],
)
const clearAllCachedData = useCallback(() => {
setCachedData({})
Expand All @@ -100,13 +100,20 @@ const DataLoaderProvider = ({ children }) => {
)
}, [])

const getCachedData = useCallback(key => {
if (key) {
return cachedData.current[key] || undefined
}
const getCachedData = useCallback(
key => {
if (key) {
return (
cachedData.current[
`${cacheKeyPrefix ? `${cacheKeyPrefix}-` : ''}${key}`
] || undefined
)
}

return cachedData.current
}, [])
return cachedData.current
},
[cacheKeyPrefix],
)

const getReloads = useCallback(key => {
if (key) {
Expand Down Expand Up @@ -151,9 +158,14 @@ const DataLoaderProvider = ({ children }) => {
}

DataLoaderProvider.propTypes = {
cacheKeyPrefix: PropTypes.string,
children: PropTypes.node.isRequired,
}

DataLoaderProvider.defaultProps = {
cacheKeyPrefix: undefined,
}

export const useDataLoaderContext = () => useContext(DataLoaderContext)

export default DataLoaderProvider
49 changes: 49 additions & 0 deletions packages/use-dataloader/src/__tests__/DataLoaderProvider.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import DataLoaderProvider, { useDataLoaderContext } from '../DataLoaderProvider'
const wrapper = ({ children }) => (
<DataLoaderProvider>{children}</DataLoaderProvider>
)

const wrapperWithCacheKey = ({ children }) => (
<DataLoaderProvider cacheKeyPrefix="sample">{children}</DataLoaderProvider>
)

describe('DataLoaderProvider', () => {
test('should render correctly', async () => {
render(<DataLoaderProvider>Test</DataLoaderProvider>)
Expand All @@ -23,6 +28,22 @@ describe('DataLoaderProvider', () => {
expect(Object.values(result.current.getCachedData()).length).toBe(1)
expect(result.current.getCachedData().test).toBe('test')
})

test('should add cached data with cacheKeyPrefix', async () => {
const { result } = renderHook(useDataLoaderContext, {
wrapper: wrapperWithCacheKey,
})
expect(result.current.getCachedData()).toStrictEqual({})

act(() => {
result.current.addCachedData('test', 'test')
result.current.addCachedData(3, 'testWrong')
})

expect(Object.values(result.current.getCachedData()).length).toBe(1)
expect(result.current.getCachedData()['sample-test']).toBe('test')
})

test('should delete cached data', async () => {
const { result } = renderHook(useDataLoaderContext, { wrapper })

Expand All @@ -49,6 +70,34 @@ describe('DataLoaderProvider', () => {
expect(result.current.getCachedData()).toStrictEqual({})
})

test('should delete cached data with cacheKeyPrefix', async () => {
const { result } = renderHook(useDataLoaderContext, {
wrapper: wrapperWithCacheKey,
})

act(() => {
result.current.addCachedData('testA', 'testA')
result.current.addCachedData('testB', 'testB')
result.current.addCachedData('testC', 'testC')
result.current.addCachedData('testD', 'testD')
result.current.addCachedData('testE', 'testE')
})
expect(result.current.getCachedData('testA')).toBe('testA')

act(() => {
result.current.clearCachedData()
result.current.clearCachedData('testA')
})
expect(Object.values(result.current.getCachedData()).length).toBe(4)
expect(result.current.getCachedData().testA).toBe(undefined)

act(() => {
result.current.clearAllCachedData()
})
expect(Object.values(result.current.getCachedData()).length).toBe(0)
expect(result.current.getCachedData()).toStrictEqual({})
})

test('should get cached data', async () => {
const { result } = renderHook(useDataLoaderContext, { wrapper })
expect(result.current.getCachedData()).toStrictEqual({})
Expand Down