Skip to content

fix(cookie-consent): use conditional access to document #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(cookie-consent): use conditional access to document #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f84d22
fix(cookie-consent): use conditional access to document
Slashgear Jun 13, 2024
ee73ad9
Merge branch 'main' into fix-cookie-consent
philibea Jun 17, 2024
4846e5a
Merge branch 'main' into fix-cookie-consent
philibea Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sharp-buckets-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@scaleway/cookie-consent": patch
---

Cookie consent provider now work on client and server side
3 changes: 2 additions & 1 deletion packages/cookie-consent/src/CookieConsentProvider/CookieConsentProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { useSegmentIntegrations } from './useSegmentIntegrations'

const COOKIE_PREFIX = '_scw_rgpd'
const HASH_COOKIE = `${COOKIE_PREFIX}_hash`
const IS_CLIENT = typeof document !== 'undefined'

// Appx 13 Months
const CONSENT_MAX_AGE = 13 * 30 * 24 * 60 * 60
Expand Down Expand Up @@ -72,7 +73,7 @@ export const CookieConsentProvider = ({
}>) => {
const [needConsent, setNeedsConsent] = useState(false)
const [cookies, setCookies] = useState<Record<string, string>>(
cookie.parse(document.cookie),
IS_CLIENT ? cookie.parse(document.cookie) : {},
)

const {
Expand Down