Skip to content

Conversation

@DorianMaliszewski
Copy link
Member

What I did

  • Fix when enabled change it will run useEffect too handle the request (when disable by default and then enabling isIdle still true so no useEffect)
  • Drop unsued ref to onSuccess and onError

@DorianMaliszewski DorianMaliszewski self-assigned this May 31, 2021
@DorianMaliszewski DorianMaliszewski added the enhancement New feature or request label May 31, 2021
@DorianMaliszewski DorianMaliszewski force-pushed the fix/effect-improvments branch from a3bc384 to 301b421 Compare May 31, 2021 09:34
@DorianMaliszewski DorianMaliszewski force-pushed the fix/effect-improvments branch from 301b421 to a06b9ca Compare May 31, 2021 09:35
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #213 (a06b9ca) into master (ad5d479) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          275       273    -2     
  Branches        40        40           
=========================================
- Hits           275       273    -2     
Impacted Files Coverage Δ
packages/use-dataloader/src/useDataLoader.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5d479...a06b9ca. Read the comment docs.

@DorianMaliszewski DorianMaliszewski merged commit abe7409 into master May 31, 2021
@DorianMaliszewski DorianMaliszewski deleted the fix/effect-improvments branch May 31, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants