Skip to content

Conversation

@philibea
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: fb17245

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/cookie-consent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (1e77335) to head (fb17245).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...CookieConsentProvider/SegmentConsentMiddleware.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   91.28%   91.29%   +0.01%     
==========================================
  Files          47       47              
  Lines        2375     2378       +3     
  Branches      104      105       +1     
==========================================
+ Hits         2168     2171       +3     
  Misses        196      196              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philibea philibea merged commit 6789326 into main Dec 30, 2024
7 checks passed
@philibea philibea deleted the fix-cookies-1 branch December 30, 2024 16:16
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
cookiesOptions?: SerializeOptions
}>) => {
const [needConsent, setNeedsConsent] = useState(false)
console.debug('document cookie', document.cookie)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philibea petit oubli ici, ce petit statement nous casse la pipeline

DorianMaliszewski pushed a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants