Skip to content

fix(regex): exclude @ as first letter for password regex #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
+8 −2
Merged

fix(regex): exclude @ as first letter for password regex #2536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-worms-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@scaleway/regex": patch
---

fix(regex): exclude @ as first letter for password regex
1 change: 1 addition & 0 deletions packages/regex/src/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,6 +1126,7 @@ describe('@regex', () => {
['Password123!@#', true],
['password`', false],
['Password`123!@#', false],
['@Password123!@#', false],
])('should match regex %s to be %s', (string, expected) => {
expect(password.test(string)).toBe(expected)
})
Expand Down
4 changes: 2 additions & 2 deletions packages/regex/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,5 @@ export const absolutePath = /^\/(([\w. -]*)[^\s?]\/?)+$/
export const sgPortRange =
/^(6553[0-5]|655[0-2][0-9]|65[0-4][0-9]{2}|6[0-4][0-9]{3}|[1-5]?[0-9]{1,4})(-(6553[0-5]|655[0-2][0-9]|65[0-4][0-9]{2}|6[0-4][0-9]{3}|[1-5]?[0-9]{1,4}))?$/

// Include all characters except backtick `
export const password = /^[^`]+$/
// Include all characters except backtick ` and @ as first character
export const password = /^(?!@)[^`]*$/
Loading